bpo-39320: Handle unpacking of *values in compiler #17984
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…them to implement star unpacking expressions.
…odes as they are now unused.
markshannon force-pushed the handle-unpacking-in-compiler branch 2 times, most recently from 1f851c4 to 5dbab06 Compare markshannon force-pushed the handle-unpacking-in-compiler branch from 5dbab06 to f920034 Compare markshannon added the 🔨 test-with-buildbots 
| 🤖 New build scheduled with the buildbot fleet by @markshannon for commit f920034 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
bedevere-bot removed the 🔨 test-with-buildbots Member Author
| The PPC64 Fedora failure is a pre-existing problem. |
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
* Add three new bytecodes: LIST_TO_TUPLE, LIST_EXTEND, SET_UPDATE. Use them to implement star unpacking expressions. * Remove four bytecodes BUILD_LIST_UNPACK, BUILD_TUPLE_UNPACK, BUILD_SET_UNPACK and BUILD_TUPLE_UNPACK_WITH_CALL opcodes as they are now unused. * Update magic number and dis.rst for new bytecodes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Quoting bpo 39320:
We can replace the complex bytecodes used in unpacking with simpler, more focused ones.
Specifically the collection building operations:
can be replaced with simpler, and self-explanatory operations:
This PR implements those changes. (The proposed changes to ** unpacking will be implemented in another PR).
https://bugs.python.org/issue39320