bpo-39320: Handle unpacking of **values in compiler #18141
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
markshannon force-pushed the handle-dict-unpacking-in-compiler branch from b6ad237 to 95e421c Compare 
pablogsal reviewed Jan 23, 2020
| @@ -0,0 +1,12 @@ | |||
| | |||
| Replace two complex bytecodes for building dicts with two simpler ones. | |||
| | |||
Member
There was a problem hiding this comment.
Different paragraphs render badly when joining the NEWS entries, sadly
markshannon added the 🔨 test-with-buildbots 
| 🤖 New build scheduled with the buildbot fleet by @markshannon for commit 2d2fe4c 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
bedevere-bot removed the 🔨 test-with-buildbots 
Member
| The failures in |
Member Author
| OK, merging. |
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
* Add DICT_UPDATE and DICT_MERGE bytecodes. Use them for ** unpacking. * Remove BUILD_MAP_UNPACK and BUILD_MAP_UNPACK_WITH_CALL, as they are now unused. * Update magic number for ** unpacking opcodes. * Update dis.rst to incorporate new bytecodes. * Add blurb entry.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This is the second part of the implementation of bpo-39320.
Part 1 was #17984
This PR replaces BUILD_MAP_UNPACK and BUILD_MAP_UNPACK_WITH_CALL
with DICT_MERGE and DICT_UPDATE.
DICT_UPDATE ncallsitem_n.update(tos)whereitem_nis thenth item on the stack andtosis popped from the stack.DICT_MERGE nis the same, but raises an exception if there are duplicate keys.https://bugs.python.org/issue39320