Provide DB backed implementation of RegistryStateService #191
+1,526 −153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This mirrors the previous PR which provided a file backed implementation. This will be wired in a future PR. Note that I changed the DB schema to match the existing sync status structure to simplify implementation. I also added a uniqueness constraint since we now assume that there is only one row in registry_sync per registry.
dmjb commented Nov 25, 2025
| fnames, err := fs.Glob(migrationsFS, "migrations/*.up.sql") | ||
| require.NoError(t, err) | ||
| | ||
| // Test each migration individually: apply, rollback, re-apply |
Member Author
There was a problem hiding this comment.
This test was broken. The problem only appeared when we had more than one migration.
dmjb commented Nov 26, 2025
| | ||
| // Set hash fields if present | ||
| if dbSync.LastSyncHash != nil { | ||
| syncStatus.LastSyncHash = *dbSync.LastSyncHash |
Member Author
There was a problem hiding this comment.
I think we should eventually get rid of the hashing, but I want to keep it now to minimize changes.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@ ## main #191 +/- ## ========================================== - Coverage 66.58% 63.18% -3.41% ========================================== Files 60 61 +1 Lines 3765 4080 +315 ========================================== + Hits 2507 2578 +71 - Misses 1101 1345 +244 Partials 157 157 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rdimitrov reviewed Nov 26, 2025
rdimitrov approved these changes Nov 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This mirrors the previous PR which provided a file backed implementation. This will be wired in a future PR.
Note that I changed the DB schema to match the existing sync status structure to simplify implementation. I also added a uniqueness constraint since we now assume that there is only one row in registry_sync per registry.