- Notifications
You must be signed in to change notification settings - Fork 4
Provide DB backed implementation of RegistryStateService #191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dmjb wants to merge 4 commits into main Choose a base branch from db-sync-status
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
+1,526 −153
Open
Changes from all commits
Commits
Show all changes
4 commits Select commit Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
10 changes: 10 additions & 0 deletions 10 database/migrations/000002_registry_sync_unique_reg_id.down.sql
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| -- Remove additional status fields and unique constraint from registry_sync table | ||
| | ||
| -- Remove the additional columns (in reverse order from up migration) | ||
| ALTER TABLE registry_sync DROP COLUMN server_count; | ||
| ALTER TABLE registry_sync DROP COLUMN last_applied_filter_hash; | ||
| ALTER TABLE registry_sync DROP COLUMN last_sync_hash; | ||
| ALTER TABLE registry_sync DROP COLUMN attempt_count; | ||
| | ||
| -- Remove the unique constraint | ||
| ALTER TABLE registry_sync DROP CONSTRAINT registry_sync_reg_id_key; |
13 changes: 13 additions & 0 deletions 13 database/migrations/000002_registry_sync_unique_reg_id.up.sql
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| -- Add unique constraint and additional status fields to registry_sync table | ||
| -- This ensures that each registry can only have one sync status record | ||
| -- and matches the fields in the SyncStatus struct | ||
| | ||
| -- Add unique constraint on reg_id | ||
| ALTER TABLE registry_sync ADD CONSTRAINT registry_sync_reg_id_key UNIQUE (reg_id); | ||
rdimitrov marked this conversation as resolved. Show resolved Hide resolved | ||
| | ||
| -- Add missing fields from SyncStatus struct | ||
| -- Use BIGINT for count fields to support 64-bit integers | ||
| ALTER TABLE registry_sync ADD COLUMN attempt_count BIGINT NOT NULL DEFAULT 0; | ||
| ALTER TABLE registry_sync ADD COLUMN last_sync_hash TEXT; | ||
| ALTER TABLE registry_sync ADD COLUMN last_applied_filter_hash TEXT; | ||
| ALTER TABLE registry_sync ADD COLUMN server_count BIGINT NOT NULL DEFAULT 0; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test was broken. The problem only appeared when we had more than one migration.