ci: updated github actions ci workflow#6314
Merged
UlisesGascon merged 1 commit intoexpressjs:masterfrom Feb 5, 2025
Merged
Conversation
bjohansebas approved these changes Feb 3, 2025
UlisesGascon approved these changes Feb 3, 2025
wesleytodd approved these changes Feb 4, 2025
Member
| I will merge this PR as currently has a fix for our broken CI (example) |
Member
| @Phillip9587 do you mind to port this to |
Phillip9587 added a commit to Phillip9587/express that referenced this pull request Feb 5, 2025
wesleytodd pushed a commit that referenced this pull request Feb 12, 2025
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

I noticed that the current CI workflow in this repository could benefit from some updates. Specifically:
Deprecation of Artifact Actions v3:
actions/upload-artifact@v3andactions/download-artifact@v3actions are being deprecated as of November 30, 2024 (GitHub Deprecation Notice).debugto ^4.4.0 #6313The Coverage setup could also be optimized:
coverallsapp/github-action@masterwhich points to v1 of this action. This v1 action usesnode16as runtime which is deprecated.Minimum token permissions for the GITHUB_TOKEN:
lint step install only dev dependencies
lintstep currently tries to install only the dev dependencies with the--only=devcli argument.--only=devhas been replaced with--include=devsince npm v7. https://docs.npmjs.com/cli/v11/commands/npm-install#include