cURL doesn't seem to work in a while loop

Question

I'll just post the whole thing since it would be a bit confusing otherwise:

<?php echo "<html> <head> <title>ARMORY.</title> <meta http-equiv='Content-Type' content='text/html' charset=iso-8859-1> </head> <body> <table width='50%' border='1' cellpadding='10' cellspacing='10'>"; $server = "Sunstrider"; $guild = "Mist"; $url='http://eu.wowarmory.com/guild-info.xml?r='.$server.'&gn='.$guild.'&p=1'; $ch = curl_init(); curl_setopt ($ch, CURLOPT_URL, $url); curl_setopt ($ch, CURLOPT_RETURNTRANSFER, true); curl_setopt ($ch, CURLOPT_USERAGENT, "Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.1) Gecko/20061204 Firefox/2.0.0.1"); $xml = curl_exec($ch); $rosterxml = new SimpleXMLElement($xml); curl_close($ch); $array = array(); foreach($rosterxml->guildInfo->guild->members->character as $char) if(strtolower($char['level']) === '80') { $array[] = $char['name']."<br />"; } echo " <tr> <td valign='middle'>Name</td> <td valign='middle'>TEST</td> </tr>"; $i = 0; while($array[$i] != null) { $name = $array[$i]; $raidurl='http://eu.wowarmory.com/character-achievements.xml?r='.$server.'&cn='.$name.'&c=168'; $ch = curl_init(); curl_setopt ($ch, CURLOPT_URL, $raidurl); curl_setopt ($ch, CURLOPT_RETURNTRANSFER, true); curl_setopt ($ch, CURLOPT_USERAGENT, "Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.1) Gecko/20061204 Firefox/2.0.0.1"); $xml2 = curl_exec($ch); $achievementxml = new SimpleXMLElement($xml2); curl_close($ch); var_dump($achievement); echo "<tr> <td>$array[$i]</td> <td></td> </tr>"; $i++; } ?> </body> </html>

That var_dump of $achievement just produces NULL over and over again (obviously due to the loop) instead of any information about the array. Doing a var_dump of $rosterxml produces the expected effect though, so cURL seems to work fine outside of the while loop.

Have you tested the URL it is attempting to access inside the loop? — Fosco
– Fosco, Commented Jul 21, 2010 at 18:46
See here how to handle curl errors : fr.php.net/manual/en/function.curl-error.php — greg0ire
– greg0ire, Commented Jul 21, 2010 at 18:47
I still like the libxml_set_streams_context() anti-user-agent-sniffing solution better :) — Wrikken
– Wrikken, Commented Jul 21, 2010 at 18:53
You don't need to constantly instantiate a new curl for every loop iteration. Do that outside the loop along with the useragent/returntransfer options, and just change the URL inside the loop. Curl objects can be reused for multiple requests. As well, never assume the curl exec succeeded as you are. Always check if it returns FALSE (ie: failed) — Marc B
– Marc B, Commented Jul 22, 2010 at 3:09

Daniel Egeberg · Accepted Answer · 2010-07-21 18:46:11Z

5

That is because your variable is called $achievementxml and not $achievement.

I would advise you to code with error_reporting=E_ALL so you can catch errors like this. Undefined variables will result in an E_NOTICE level error message.

answered Jul 21, 2010 at 18:46

Daniel Egeberg

8,38233 silver badges44 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

greg0ire Over a year ago

+1, when developing, you can even use E_ALL | E_STRICT to get maximum verbosity.

James Over a year ago

Aha, it would appear that I am an idiot. Thanks, and thanks for the advice. I'm quite new to PHP as you might be able to tell, and I'm probably not helping matters by keeping my code completely devoid of comments, but there you have it!

Wrikken Over a year ago

Or the shortcut: -1 (which would set all bits), so possibly even new thought op E_* constants in future, until we get a E_REALLY_ALL

Collectives™ on Stack Overflow

cURL doesn't seem to work in a while loop

1 Answer 1

3 Comments

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

3 Comments

Related