For Asp.net Core apps, which one do we have to use? AddDbContext or AddDbContextPool? According to EF Core documentation, AddDbContextPool provides high performance but the default Asp.net Core project templates use AddDbContext.
1 Answer
The answer is here (under "DbContext pooling"): https://learn.microsoft.com/en-us/ef/core/what-is-new/ef-core-2.0#dbcontext-pooling
DbContext is not thread-safe. So you cannot reuse the same DbContext object for multiple queries at the same time (weird things happen). The usual solution for this has been to just create a new DbContext object each time you need one. That's what AddDbContext does.
However, there is nothing wrong with reusing a DbContext object after a previous query has already completed. That's what AddDbContextPool does. It keeps multiple DbContext objects alive and gives you an unused one rather than creating a new one each time.
Which one you use is up to you. Both will work. Pooling has some performance gains. However the documentation warns that if you use any private properties in your DbContext class that should not be shared between queries, then you should not use it. I imagine that's pretty rare though, so pooling should be appropriate in most cases.
11 Comments
SaveChanges() and closes it automatically. So it only might be an issue if you create a transaction manually and don't close it off.DbContext is returned to the context pool, the state of the context is being reset by calling its IResettableService.ResetState() method. This method in turn calls the GetResettableServices() method and then calls IResettableService.ResetState() on the returned objects as well. One of those objects is the EF Core providers RelationalConnection derived object, because it implements IResettableService as well. The default implementation of ResetState() in RelationalConnection is to call its own Dispose() method, which in turn calls DbConnection.Dispose().
AddDbContextPool. High-performance means 2000-5000 requests (per machine you are running your apps on) per second. 100 requests / min is no high performance and you are good with the defaultsDbContextfor parallel queries - willAddDbContextPoolbe simpler since it does this automatically? Any downsides?DbContextper scope from dependency injection.